feat(fe): ICRC-3 attribute consent UI with store-driven rendering#3790
Open
sea-snake wants to merge 2 commits intosea-snake/unified-authorize-routefrom
Open
feat(fe): ICRC-3 attribute consent UI with store-driven rendering#3790sea-snake wants to merge 2 commits intosea-snake/unified-authorize-routefrom
sea-snake wants to merge 2 commits intosea-snake/unified-authorize-routefrom
Conversation
62de7bb to
0d7f581
Compare
30c0b45 to
1d20f5a
Compare
0d7f581 to
7d43bc7
Compare
Add a consent view that lets users review and choose which attributes to share before they are certified. The handler resolves available attributes via list_available_attributes, then the UI presents them with checkboxes and an optional provider picker for unscoped keys. - Attribute consent store (context as promise + consent result) - AttributeConsentView with skeleton loading and merged email/verified_email - AttributePicker with inline expandable dropdown - Implicit consent detection via pendingOpenIdIssuerStore - Skeleton CSS utility class - Accessible markup (fieldset, listbox, aria attributes)
238df1c to
fedbaf5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a dapp requests ICRC-3 attributes, users previously had no way to review or choose which attributes to share — everything was handled via implicit consent. This PR adds a consent UI that lets users review requested attributes, pick from available options (e.g., which provider's email to share), and deny sharing entirely.
Changes
pendingOpenIdIssuerStoreset early in the OpenID resume flow for synchronous detection..skeletonclass with shimmer animation usingcolor-mixfor theme-adaptive appearance.{#await}s the context promise — shows skeleton while resolving, then the real content.<fieldset>,role="listbox"/role="option",aria-expanded,aria-selected,aria-busyon loading state.