feat(fe): handle ICRC-3 attribute requests in default authorize flow#3791
Open
sea-snake wants to merge 2 commits intosea-snake/icrc3-text-typesfrom
Open
feat(fe): handle ICRC-3 attribute requests in default authorize flow#3791sea-snake wants to merge 2 commits intosea-snake/icrc3-text-typesfrom
sea-snake wants to merge 2 commits intosea-snake/icrc3-text-typesfrom
Conversation
This was referenced Apr 20, 2026
0a5cf6d to
151d340
Compare
Listen for ii-icrc3-attributes requests in the normal (non-OpenID) authorize flow. Responds with empty attributes (only implicit entries like nonce, origin, timestamp) since the user didn't authenticate via OpenID and has no attribute values to certify.
1297a30 to
8d7cdb2
Compare
aterga
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ICRC-3 attribute handler previously only existed in the OpenID resume flow. Dapps using the default (non-OpenID) authorize flow that request
ii-icrc3-attributeswould get no response.This adds an ICRC-3 attributes listener to the default authorize flow's
AuthorizationChannel. Since the user didn't authenticate via OpenID, there are no attribute values to certify — the handler responds with only the implicit entries (nonce, origin, timestamp) by callingprepare_icrc3_attributeswith an empty attributes list.Changes
handleIcrc3AttributeRequeststoAuthorizationChannel.sveltethat listens forii-icrc3-attributes, waits for authorization + authentication, then certifies an empty attribute set.