docs: update Node.js version requirement in HACKING.md#3792
Closed
timothyaterton wants to merge 1 commit intodfinity:mainfrom
Closed
docs: update Node.js version requirement in HACKING.md#3792timothyaterton wants to merge 1 commit intodfinity:mainfrom
timothyaterton wants to merge 1 commit intodfinity:mainfrom
Conversation
The documented requirement (v16+) is stale — the project now requires Node.js v24 (see .nvmrc and package.json engines field). Update the prerequisite to match.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor documentation to reflect the repository’s current Node.js requirement, aligning HACKING.md with the Node version pinned/enforced elsewhere in the repo.
Changes:
- Update the documented Node.js prerequisite in
HACKING.mdfrom v16+ to v24 (with a reference to.nvmrc).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - CMake | ||
| - [`ic-wasm`](https://github.com/dfinity/ic-wasm), which can be installed by running [./scripts/bootstrap](./scripts/bootstrap) | ||
| - Node.js v16+ | ||
| - Node.js v24+ (see `.nvmrc` for the exact version) |
| - CMake | ||
| - [`ic-wasm`](https://github.com/dfinity/ic-wasm), which can be installed by running [./scripts/bootstrap](./scripts/bootstrap) | ||
| - Node.js v16+ | ||
| - Node.js v24+ (see `.nvmrc` for the exact version) |
Contributor
Author
|
Closing — this was a smoke-test PR to exercise the temate → dfinity/internet-identity automation end-to-end. The temate-side PR merged prematurely due to a race (now fixed in timothyaterton/temate#93), so this upstream PR was never followed through. Restarting the experiment fresh. Note: the underlying issue ('HACKING.md says Node.js v16+ but .nvmrc pins 24.x') is real — a follow-up PR may still land it as a genuine doc contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Node.js prerequisite listed in
HACKING.mdsays v16+, but the projectactually requires Node.js v24 — see
.nvmrc(pinned at24.15.0) andpackage.json(engines.node: ">=24.0.0 <25.0.0").This one-line fix updates the documented requirement to match reality so that
new contributors don't waste time with an unsupported Node version.
Changes
HACKING.mdline 15:Node.js v16+→Node.js v24+ (see .nvmrc for the exact version)