docs: update Node.js version requirement in HACKING.md#3793
Open
timothyaterton wants to merge 2 commits intodfinity:mainfrom
Open
docs: update Node.js version requirement in HACKING.md#3793timothyaterton wants to merge 2 commits intodfinity:mainfrom
timothyaterton wants to merge 2 commits intodfinity:mainfrom
Conversation
HACKING.md listed Node.js v16+ as a prerequisite, but the project requires Node.js v24 (.nvmrc pins 24.15.0, package.json engines require >=24.0.0 <25.0.0). Update the documented requirement so new contributors install the correct version.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates contributor build documentation to reflect the project’s current Node.js requirement, aligning HACKING.md with the Node version enforced by repository tooling.
Changes:
- Update the documented Node.js prerequisite in
HACKING.mdfrom v16+ to v24+ and reference.nvmrcfor the exact version.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HACKING.mdlists Node.js v16+ as a build prerequisite, but the projectactually requires Node.js v24:
.nvmrc24.15.0package.jsonengines>=24.0.0 <25.0.0New contributors following the current docs would install a Node version
that's eight major versions behind and incompatible with the project.
Changes
HACKING.mdline 15:Node.js v16+→Node.js v24+ (see .nvmrc for the exact version)This is a one-line documentation fix with no code changes.