DRAFT: feat(transactions): detect burn address in ICRC token send flow#7831
Draft
DRAFT: feat(transactions): detect burn address in ICRC token send flow#7831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When a user sends ICRC/SNS tokens to the minting account (which is the burn address in ICRC-1), the transaction incurs no fee. It should be clear to the user that they are burning tokens, not just sending them to a regular address.
Changes
queryIcrcMintingAccountAPI function to fetch the minting account from an ICRC-1 ledger canister.IcrcTokenTransactionModaland passed it down asburnAddress.burnAddressprop toTransactionModalandTransactionFormto propagate the burn address through the send flow.0nas the effective fee when the destination is the burn address, both for the maximum amount calculation and the actual transfer.Tests
Todos