Skip to content

refactor(frontend): clean up HelpMenu-related code#12292

Merged
DenysKarmazynDFINITY merged 1 commit intomainfrom
refactor(frontend)/remove-help-menu
Apr 2, 2026
Merged

refactor(frontend): clean up HelpMenu-related code#12292
DenysKarmazynDFINITY merged 1 commit intomainfrom
refactor(frontend)/remove-help-menu

Conversation

@DenysKarmazynDFINITY
Copy link
Copy Markdown
Contributor

Motivation

Since the HelpMenu component is no longer used, we can clean up quite a few things.

@DenysKarmazynDFINITY DenysKarmazynDFINITY requested a review from a team as a code owner April 2, 2026 08:42
Copilot AI review requested due to automatic review settings April 2, 2026 08:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused HelpMenu component and its associated dependencies as part of a refactoring effort to clean up unused code. The changes include deletion of the HelpMenu component itself, the ChangelogLink component, the IconChangelog icon component, removal of changelog-related i18n strings across all supported languages, removal of the changelog tracking constant, and deletion of the associated test file.

Changes:

  • Deleted the HelpMenu.svelte component (95 lines) and its test file
  • Removed ChangelogLink.svelte component and IconChangelog.svelte icon
  • Removed TRACK_COUNT_OPEN_CHANGELOG tracking constant from analytics
  • Removed changelog entries from i18n type definitions and all 16 supported language JSON files
  • Updated type definitions to match the removed i18n properties

Reviewed changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/frontend/src/tests/lib/components/core/HelpMenu.spec.ts Deleted test file (55 lines)
src/frontend/src/lib/components/core/HelpMenu.svelte Deleted main HelpMenu component (95 lines)
src/frontend/src/lib/components/navigation/ChangelogLink.svelte Deleted ChangelogLink component (30 lines)
src/frontend/src/lib/components/icons/lucide/IconChangelog.svelte Deleted icon component (29 lines)
src/frontend/src/lib/types/i18n.d.ts Removed two changelog type definitions from I18nNavigation interface
src/frontend/src/lib/constants/analytics.constants.ts Removed TRACK_COUNT_OPEN_CHANGELOG constant
src/frontend/src/lib/i18n/*.json (16 files) Removed changelog entries from text and alt sections of all language files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!! Tks

@DenysKarmazynDFINITY DenysKarmazynDFINITY added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 3106fb5 Apr 2, 2026
85 checks passed
@DenysKarmazynDFINITY DenysKarmazynDFINITY deleted the refactor(frontend)/remove-help-menu branch April 2, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants