fix(frontend): include HiddenMicroTransactionsInfoBox in AllTransactions banners logic#12619
Merged
AntonioVentilii merged 5 commits intomainfrom Apr 28, 2026
Conversation
…ons hasBanners Expose visibility from HiddenMicroTransactionsInfoBox via a $bindable prop and factor it into the hasBanners derivation in AllTransactions.
AntonioVentilii
changed the title
HiddenMicroTransactionsInfoBox in AllTransactions banners logic
…ns-in-has-banners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the transactions page banner derivation so the “Hidden micro-transactions” info box can participate in the hasBanners calculation, enabling the layout logic to account for its visibility.
Changes:
- Expose
HiddenMicroTransactionsInfoBoxvisibility via an optional bindablevisibleprop, synced with its internal visibility logic. - Bind that
visiblevalue inAllTransactions.svelteand include it in thehasBannersderivation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/src/lib/components/transactions/HiddenMicroTransactionsInfoBox.svelte |
Adds optional bindable visible prop and syncs it from internal computed visibility. |
src/frontend/src/lib/components/transactions/AllTransactions.svelte |
Tracks info-box visibility via binding and incorporates it into hasBanners. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ns-in-has-banners
…ers wrapper
Lift the visibility and dismissal logic into AllTransactions so the banner
is rendered inline within the {#if hasBanners} wrapper, avoiding an empty
wrapper div (and stray gap-5 spacing) when it is the only visible banner.
Revert the now-unneeded $bindable visible prop on HiddenMicroTransactionsInfoBox.
Extract the visibility computation for the hidden micro-transactions info banner into a shared `hiddenMicroTransactionsBannerVisible` derived so the component can stay reusable while parents (e.g. `AllTransactions`) can include its visibility in `hasBanners` and render it inside the banners wrapper without duplicating logic.
DenysKarmazynDFINITY
approved these changes
Apr 28, 2026
AntonioVentilii
deleted the
fix-frontend-include-hidden-micro-transactions-in-has-banners
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
hasBannersderivation inAllTransactions.sveltedecides whether the banners wrapper renders, but it was not aware ofHiddenMicroTransactionsInfoBox's visibility. As a result, the hidden-micro-transactions info box was not considered a banner for layout/derivation purposes.Changes
HiddenMicroTransactionsInfoBoxvia an optional$bindableprop.AllTransactionsand include it inhasBanners.