feat(frontend): implement SwapDetailsOneSec component#12627
Merged
DenysKarmazynDFINITY merged 1 commit intomainfrom Apr 28, 2026
Merged
feat(frontend): implement SwapDetailsOneSec component#12627DenysKarmazynDFINITY merged 1 commit intomainfrom
DenysKarmazynDFINITY merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a new swap-details UI component specific to the OneSec provider, along with i18n keys and a test suite to validate fee rendering/formatting.
Changes:
- Added
SwapDetailsOneSecSvelte component to display OneSec transfer fee and protocol fee. - Added i18n keys for OneSec fee labels across all supported locales (with English strings provided).
- Added a unit test suite covering protocol-fee formatting and conditional rendering of the transfer-fee row.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/lib/components/swap/SwapDetailsOneSec.svelte | New component that renders OneSec-specific fee rows using swap context + i18n. |
| src/frontend/src/tests/lib/components/swap/SwapDetailsOneSec.spec.ts | Tests for OneSec fee labels, formatting, and conditional rendering. |
| src/frontend/src/lib/types/i18n.d.ts | Extends swap i18n typings with OneSec fee label keys. |
| src/frontend/src/lib/i18n/en.json | Adds English strings for OneSec transfer/protocol fee labels. |
| src/frontend/src/lib/i18n/ar.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/cs.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/de.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/es.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/fr.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/hi.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/it.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/ja.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/ko-KR.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/pl.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/pt.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/ru.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/vi.json | Adds OneSec i18n keys (empty → fallback). |
| src/frontend/src/lib/i18n/zh-CN.json | Adds OneSec i18n keys (empty → fallback). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AntonioVentilii
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We need to implement a component for displaying an information about the OneSec provider.