Skip to content

refactor(frontend): Small fix and tests modal token list #5938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Apr 22, 2025

Conversation

daviddecentage
Copy link
Collaborator

@daviddecentage daviddecentage commented Apr 17, 2025

Motivation

Adding tests to up coverage so I can merge #5882. The tested component is used there so it is related.

Changes

  • Adding testIds and tests
  • Small fix regarding <p> in <p> warning

Tests

Added tests

@daviddecentage daviddecentage requested a review from a team as a code owner April 17, 2025 15:13
@daviddecentage daviddecentage marked this pull request as draft April 17, 2025 15:15
@daviddecentage daviddecentage changed the title refactor(frontend): add tests modal token list refactor(frontend): Add tests modal token list Apr 17, 2025
@daviddecentage daviddecentage changed the title refactor(frontend): Add tests modal token list refactor(frontend): Small fix and tests modal token list Apr 17, 2025
@daviddecentage daviddecentage marked this pull request as ready for review April 17, 2025 15:49
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tks!

@daviddecentage daviddecentage enabled auto-merge (squash) April 22, 2025 11:35
@daviddecentage daviddecentage merged commit 44e6a3d into main Apr 22, 2025
28 checks passed
@daviddecentage daviddecentage deleted the refactor(frontend)/add-tests-modal-token-list branch April 22, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants