refactor(frontend): Use AppPath mapping for all href redirections#9343
Merged
AntonioVentilii merged 12 commits intomainfrom Mar 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the frontend to use centralized AppPath mapping for all href redirections instead of hard-coded paths, improving maintainability and consistency.
- Created a new
pathToHrefutility function to convertAppPathvalues to href strings - Added new
AppPathentries for license agreement, privacy policy, and terms of use pages - Replaced hard-coded href values in multiple components with centralized path references
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/frontend/src/lib/utils/nav.utils.ts | Added pathToHref utility function to convert AppPath to href format |
| src/frontend/src/lib/constants/routes.constants.ts | Added new AppPath entries for agreement pages |
| src/frontend/src/tests/lib/utils/nav.utils.spec.ts | Added comprehensive tests for the new pathToHref function |
| src/frontend/src/lib/components/terms-of-use/TermsOfUseLink.svelte | Replaced hard-coded href with AppPath reference |
| src/frontend/src/lib/components/privacy-policy/PrivacyPolicyLink.svelte | Replaced hard-coded href with AppPath reference |
| src/frontend/src/lib/components/license-agreement/LicenseAgreementLink.svelte | Replaced hard-coded href with AppPath reference |
| src/frontend/src/lib/components/core/OisyWalletLogoLink.svelte | Replaced hard-coded href with AppPath reference |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…l-href-redirections
…l-href-redirections
…l-href-redirections
…l-href-redirections
…l-href-redirections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have the mapping
AppPathto keep track of all the paths of our app. We should use that for allhreffor maintainability.Changes
LicenseAgreement,PrivacyPolicy, andTermsOfUsepaths to theAppPathenum.hrefvalues in link components withresolve(AppPath.X).Tests
Updated existing tests.