fix: regenerate lockfile and update workspace references#4
Open
nikosxenakis wants to merge 8 commits intomainfrom
Open
fix: regenerate lockfile and update workspace references#4nikosxenakis wants to merge 8 commits intomainfrom
nikosxenakis wants to merge 8 commits intomainfrom
Conversation
414937a to
6ba52c3
Compare
9265e0a to
21498db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonfiles to referencepic-js-mopsinstead of@dfinity/picpic-js-mopsinstead of@dfinity/picpnpm-lock.yamlandbun.lockblockfilespostinstallscript inpackages/pic/package.json(downloads PocketIC binary).js→.tsimports in test setupArrayBufferLikewith concrete types (Uint8Array,ArrayBuffer) to fix TS build under newer type definitions@types/nodeandtypescriptto exact versions to ensure bun resolves the same types as pnpmContext
The package was renamed from
@dfinity/pictopic-js-mopsand peer dependencies changed from@dfinity/*to@icp-sdk/core, but lockfiles, workspace references, example imports, and test config were not updated. Additionally, thepostinstallscript for downloading the PocketIC binary was missing frompackages/pic/package.json, andArrayBufferLiketypes became incompatible with newer TypeScript /@types/nodeversions used by bun.Changes
package.jsonand 19 example.tsfiles updated from@dfinity/pictopic-js-mopspnpm-lock.yamlandbun.lockbregenerated"postinstall": "node ./postinstall.mjs"inpackages/pic/package.jsonpocket-ic-server-types.ts,pocket-ic-server.ts,util/candid.tsmoduleNameMapperandModule._resolveFilenameshim for.js→.tsresolutionArrayBufferLikewithUint8Array | ArrayBufferinpocket-ic.ts,pocket-ic-types.ts, andcandid.ts@types/nodepinned to22.13.10,typescriptto5.8.2(removed^ranges)