Skip to content

fix: regenerate lockfile and update workspace references#4

Open
nikosxenakis wants to merge 8 commits intomainfrom
nikosxenakis/fix-stale-lockfile
Open

fix: regenerate lockfile and update workspace references#4
nikosxenakis wants to merge 8 commits intomainfrom
nikosxenakis/fix-stale-lockfile

Conversation

@nikosxenakis
Copy link
Copy Markdown

@nikosxenakis nikosxenakis commented Apr 14, 2026

Summary

  • Update 6 example test package.json files to reference pic-js-mops instead of @dfinity/pic
  • Update 19 example TypeScript files to import from pic-js-mops instead of @dfinity/pic
  • Regenerate pnpm-lock.yaml and bun.lockb lockfiles
  • Restore postinstall script in packages/pic/package.json (downloads PocketIC binary)
  • Fix prettier formatting in source files
  • Fix Jest module resolution for .js.ts imports in test setup
  • Replace ArrayBufferLike with concrete types (Uint8Array, ArrayBuffer) to fix TS build under newer type definitions
  • Pin @types/node and typescript to exact versions to ensure bun resolves the same types as pnpm

Context

The package was renamed from @dfinity/pic to pic-js-mops and peer dependencies changed from @dfinity/* to @icp-sdk/core, but lockfiles, workspace references, example imports, and test config were not updated. Additionally, the postinstall script for downloading the PocketIC binary was missing from packages/pic/package.json, and ArrayBufferLike types became incompatible with newer TypeScript / @types/node versions used by bun.

Changes

  1. Workspace references — all 6 example package.json and 19 example .ts files updated from @dfinity/pic to pic-js-mops
  2. Lockfilespnpm-lock.yaml and bun.lockb regenerated
  3. PocketIC binary — restored "postinstall": "node ./postinstall.mjs" in packages/pic/package.json
  4. Prettier — formatted pocket-ic-server-types.ts, pocket-ic-server.ts, util/candid.ts
  5. Jest config — added moduleNameMapper and Module._resolveFilename shim for .js.ts resolution
  6. TypeScript types — replaced ArrayBufferLike with Uint8Array | ArrayBuffer in pocket-ic.ts, pocket-ic-types.ts, and candid.ts
  7. Pinned devDeps@types/node pinned to 22.13.10, typescript to 5.8.2 (removed ^ ranges)

Note: Peer dependency version mismatches exist between root devDeps (@dfinity/*@2.3.0) and @icp-sdk/core@4.2.3 (expects 3.4.3). This is a pre-existing issue not addressed here.

@nikosxenakis nikosxenakis requested a review from a team as a code owner April 14, 2026 10:41
@nikosxenakis nikosxenakis force-pushed the nikosxenakis/fix-stale-lockfile branch from 414937a to 6ba52c3 Compare April 14, 2026 11:10
@nikosxenakis nikosxenakis force-pushed the nikosxenakis/fix-stale-lockfile branch from 9265e0a to 21498db Compare April 14, 2026 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant