Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ic-http-certification): add request method enum #397

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Nov 28, 2024

I took a very similar approach here as I did for response status code. Thankfully there's a lot less sweeping changes in this case though.

Additionally I noticed that I missed some docs that should've been updated with the status code change, so I fixed them too.

@nathanosdev nathanosdev marked this pull request as ready for review November 28, 2024 13:39
@nathanosdev nathanosdev requested a review from a team as a code owner November 28, 2024 13:39
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanosdev nathanosdev merged commit 3644d3f into main Dec 3, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/request-method-enum branch December 3, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants