Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ic-http-certification): add more tests to example projects #399

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

nathanosdev
Copy link
Member

@nathanosdev nathanosdev commented Dec 2, 2024

#395 must be merged before this one

@nathanosdev nathanosdev marked this pull request as ready for review December 3, 2024 13:33
@nathanosdev nathanosdev requested a review from a team as a code owner December 3, 2024 13:33
@nathanosdev nathanosdev force-pushed the nathan/skip-certification-for-path branch 2 times, most recently from 4007b24 to 4a4f561 Compare December 5, 2024 10:39
Base automatically changed from nathan/skip-certification-for-path to main December 5, 2024 13:16
@nathanosdev nathanosdev force-pushed the nathan/add-more-example-tests branch from 0008f7b to bfcebc4 Compare December 9, 2024 16:49
@nathanosdev nathanosdev enabled auto-merge (squash) December 9, 2024 16:56
przydatek
przydatek previously approved these changes Dec 11, 2024
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions. Thanks!

@nathanosdev nathanosdev merged commit b8aa830 into main Dec 12, 2024
6 checks passed
@nathanosdev nathanosdev deleted the nathan/add-more-example-tests branch December 12, 2024 10:23
nathanosdev added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants