Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ic-asset-certification): fix range response certification #420

Merged
merged 3 commits into from
Jan 23, 2025

Conversation

nathanosdev
Copy link
Member

add additional error types to ic-response-verification crate

add additional error types to ic-response-verification crate
@nathanosdev nathanosdev requested a review from a team as a code owner January 22, 2025 23:24
Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, but please see some questions below.
(Thanks a lot for the annotations to the changes, very helpful indeed!)

Copy link
Contributor

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nathanosdev nathanosdev merged commit ede16c0 into main Jan 23, 2025
7 checks passed
@nathanosdev nathanosdev deleted the nathan/fix-range-response-certification branch January 23, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants