chore: release #219
Merged
chore: release #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lpahlavi
force-pushed
the
release-plz-2025-08-29T10-49-57Z
branch
from
83990f4 to
b147871
Compare
gregorydemay
reviewed
Sep 1, 2025
Collaborator
gregorydemay
left a comment
gregorydemay
left a comment
There was a problem hiding this comment.
Thanks for preparing the release notes, some minor comments.
libs/client/CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Replace forked `solana-*` crates by latest releases ([#197](https://github.com/dfinity/sol-rpc-canister/pull/197)) |
Collaborator
There was a problem hiding this comment.
nit: maybe it's worth pointing out that these use the "official" solana crates and that the patch section is no longer necessary. E.g.
Suggested change
| - Replace forked `solana-*` crates by latest releases ([#197](https://github.com/dfinity/sol-rpc-canister/pull/197)) | |
| - Replace forked `solana-*` crates by the corresponding ones in `solana_sdk` version `3.0.0`. The `patch.crates-io` section in `Cargo.toml` is therefore no longer necessary and can be removed. ([#197](https://github.com/dfinity/sol-rpc-canister/pull/197)) |
Contributor
There was a problem hiding this comment.
I wasn't quite sure how verbose we want to be in the CHANGELOG, your suggestion is good! Done (in CHANGELOGs + PR description).
gregorydemay
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 New release
sol_rpc_types: 2.0.0 -> 3.0.0sol_rpc_canister: 1.1.0 -> 1.2.0sol_rpc_client: 2.0.0 -> 3.0.0Changelog
sol_rpc_typessol_rpc_canistersol_rpc_clientThis PR was generated with release-plz.