Skip to content

feat: CRP-2826 CRP-2827 Provide a more consistent interface in the TS API regarding serialization and deserialization#156

Merged
randombit merged 7 commits intomainfrom
jack/crp-2826-and-2827
Jun 26, 2025
Merged

feat: CRP-2826 CRP-2827 Provide a more consistent interface in the TS API regarding serialization and deserialization#156
randombit merged 7 commits intomainfrom
jack/crp-2826-and-2827

Conversation

@randombit
Copy link
Copy Markdown
Contributor

@randombit randombit commented Jun 23, 2025

No description provided.

@randombit randombit marked this pull request as ready for review June 23, 2025 19:34
@randombit randombit requested a review from a team June 23, 2025 19:34
altkdf
altkdf approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@altkdf altkdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @randombit , LGTM! Please also add to the changelogs.

fspreiss
fspreiss approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @randombit!

Comment thread frontend/ic_vetkeys/src/utils/utils.ts Outdated
Comment thread frontend/ic_vetkeys/src/utils/utils.ts
Comment thread frontend/ic_vetkeys/src/utils/utils.ts
@fspreiss
Copy link
Copy Markdown
Contributor

fspreiss commented Jun 26, 2025

Do I understand correctly, that CRP-2826 was actually already addressed before the PR? That is, VetKey did have a serialize function already for both TS and Rust.

@randombit
Copy link
Copy Markdown
Contributor Author

randombit commented Jun 26, 2025

Do I understand correctly, that CRP-2826 was actually already addressed before the PR? That is, VetKey did have a serialize function already for both TS and Rust.

No, TS was missing VetKey.serialize, this was added in this PR. There was the (equivalent) getSignatureBytes but this was thought maybe confusing for users who want the raw encoding but aren't using it for BLS signatures.

@randombit randombit merged commit 65651d5 into main Jun 26, 2025
22 checks passed
@randombit randombit deleted the jack/crp-2826-and-2827 branch June 26, 2025 21:13
@fspreiss
Copy link
Copy Markdown
Contributor

fspreiss commented Jun 27, 2025 •
edited
Loading

No, TS was missing VetKey.serialize, this was added in this PR.

Ah, indeed! I missed that, sorry! Thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fspreiss fspreiss fspreiss approved these changes

+1 more reviewer

@altkdf altkdf altkdf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@randombit @fspreiss @altkdf