Skip to content

feat: CRP-2761 CRP-2850 copy encrypted notes dapp from examples repo and prepare for deploying to ICP Ninja#162

Merged
altkdf merged 12 commits intomainfrom
alex/encrypted-notes
Jun 27, 2025
Merged

feat: CRP-2761 CRP-2850 copy encrypted notes dapp from examples repo and prepare for deploying to ICP Ninja#162
altkdf merged 12 commits intomainfrom
alex/encrypted-notes

Conversation

@altkdf
Copy link
Copy Markdown
Contributor

@altkdf altkdf commented Jun 27, 2025

No description provided.

@altkdf altkdf marked this pull request as ready for review June 27, 2025 09:58
@altkdf altkdf requested a review from a team June 27, 2025 09:58
@altkdf altkdf changed the title feat: CRP-2761 copy encrypted notes dapp from examples repo and prepare for deploying to ICP Ninja feat: CRP-2761 CRP-2850 copy encrypted notes dapp from examples repo and prepare for deploying to ICP Ninja Jun 27, 2025
Copy link
Copy Markdown
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @altkdf! Being able to deploy this with the click of a button is fantastic 🪄✨

Deployment works for both Rust and Motoko. I noticed that for Motoko ICP Ninja shows all the imports at the top of main.mo with red underlines, which is not a problem but I'm wondering if we can do anything about it.

Comment thread examples/encrypted_notes_dapp_vetkd/pictures/architectural_overview.png Outdated
@altkdf altkdf enabled auto-merge (squash) June 27, 2025 15:37
@altkdf altkdf disabled auto-merge June 27, 2025 15:37
@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Jun 27, 2025

Deployment works for both Rust and Motoko. I noticed that for Motoko ICP Ninja shows all the imports at the top of main.mo with red underlines, which is not a problem but I'm wondering if we can do anything about it.

Hm, I don't see any red lines there 🤔

@altkdf altkdf merged commit 3a7dc73 into main Jun 27, 2025
12 checks passed
@altkdf altkdf deleted the alex/encrypted-notes branch June 27, 2025 15:44
@fspreiss
Copy link
Copy Markdown
Contributor

Deployment works for both Rust and Motoko. I noticed that for Motoko ICP Ninja shows all the imports at the top of main.mo with red underlines, which is not a problem but I'm wondering if we can do anything about it.

Hm, I don't see any red lines there 🤔

Screenshot 2025-06-27 at 20 56 44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants