feat: CRP-2797 Add functions to access the production master key#171
Merged
feat: CRP-2797 Add functions to access the production master key#171
Conversation
This allows performing key derivation completely offline, without having to interact with the IC.
altkdf
reviewed
Jun 27, 2025
altkdf
reviewed
Jun 27, 2025
Contributor
There was a problem hiding this comment.
LGTM @randombit ! Just one question. If we decide to have the same API in TS as in Rust, we could also do that in another PR. Maybe we should add test_key_1 in this PR as well though?
Contributor
Author
Done. I also added a test for test_key_1 derivation that was generated using a canister on mainnet. |
Contributor
Author
|
Ah, nice. I realized |
altkdf
approved these changes
Jun 28, 2025
Contributor
altkdf
left a comment
altkdf
left a comment
There was a problem hiding this comment.
Cool, thanks @randombit ! Please alsoo add to the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows performing key derivation completely offline, without having to interact with the IC.