chore: migrate from dfx to icp-cli#370
Draft
andreacerulli wants to merge 2 commits intopr2/regenerate-declarationsfrom
Draft
chore: migrate from dfx to icp-cli#370andreacerulli wants to merge 2 commits intopr2/regenerate-declarationsfrom
andreacerulli wants to merge 2 commits intopr2/regenerate-declarationsfrom
Conversation
andreacerulli
force-pushed
the
pr3/backend-icp-cli
branch
from
9edcf45 to
cb74705
Compare
andreacerulli
force-pushed
the
pr2/regenerate-declarations
branch
from
4919412 to
0cfda3c
Compare
andreacerulli
force-pushed
the
pr3/backend-icp-cli
branch
from
cb74705 to
e0390f1
Compare
andreacerulli
force-pushed
the
pr2/regenerate-declarations
branch
2 times, most recently
from
4440390 to
7ba7132
Compare
andreacerulli
force-pushed
the
pr3/backend-icp-cli
branch
from
e0390f1 to
94fa287
Compare
dfx generate produces declarations with @dfinity/agent imports, which conflict with the migrated @icp-sdk/core source imports. Add a sed post-processing step to each gen_bindings.sh that rewrites the imports after generation. This is a temporary bridge until PR3 replaces dfx generate with @icp-sdk/bindgen entirely.
Replace dfx.json configs with icp.yaml for all backends and examples. Update gen_bindings.sh scripts to use @icp-sdk/bindgen instead of dfx generate. Update Makefiles, mops.toml, and README documentation for icp-cli commands. - Remove all dfx.json files - Add icp.yaml configs for all rust and motoko backends - Update gen_bindings.sh to use npx @icp-sdk/bindgen - Update Makefiles for icp-cli compatible builds - Update mops.toml toolchain configs - Update backend test key from dfx_test_key to test_key_1 - Update all README files with icp-cli instructions
andreacerulli
force-pushed
the
pr2/regenerate-declarations
branch
from
7ba7132 to
f91958f
Compare
andreacerulli
force-pushed
the
pr3/backend-icp-cli
branch
from
94fa287 to
f0a4965
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace dfx.json configs with icp.yaml for all backends and examples. Update gen_bindings.sh scripts to use @icp-sdk/bindgen instead of dfx generate. Update Makefiles, mops.toml, and README documentation for icp-cli commands.