Skip to content

feat: CRP-2757 implement Motoko backend#65

Merged
altkdf merged 19 commits intomainfrom
alex/mo
Apr 28, 2025
Merged

feat: CRP-2757 implement Motoko backend#65
altkdf merged 19 commits intomainfrom
alex/mo

Conversation

@altkdf
Copy link
Copy Markdown
Contributor

@altkdf altkdf commented Apr 8, 2025

Implements:

  • The actual backend.
  • Tests that don't require VetKD.
  • Github workflow.

@altkdf altkdf requested review from fspreiss and randombit April 8, 2025 10:33
@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Apr 8, 2025

The map type operations currently incur much more overhead than they should and the reason is that the map types in motoko don't yet support range functions that we need for efficiency. As it looks, this limitation should soon be removed though caffeinelabs/motoko-core#271.

@altkdf
Copy link
Copy Markdown
Contributor Author

altkdf commented Apr 8, 2025

In next PRs: motoko-based canisters, better documentation, pocket IC tests checking that the VetKD calls work as intended.

@altkdf altkdf marked this pull request as ready for review April 8, 2025 12:23
@altkdf altkdf requested a review from a team April 8, 2025 12:23
Copy link
Copy Markdown
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @altkdf! Looks generally good! Please find a few comments below.

@altkdf altkdf requested a review from fspreiss April 24, 2025 08:55
Copy link
Copy Markdown
Contributor

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments and for creating the tickets for the remaining ones, @altkdf!

@altkdf altkdf merged commit bb6cd0d into main Apr 28, 2025
16 checks passed
@randombit randombit deleted the alex/mo branch May 23, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants