chore: ethersv6 basic transfer examples #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Torakushi
reviewed
Jul 5, 2024
| - [polygon-deposit-erc20](./libs/ethersjs/v5/polygon-deposit-erc20) | ||
| - [optimism-deposit-eth](./libs/ethersjs/v5/optimism-deposit-eth) | ||
| - Ethersjs v6 integration (`@dfns/lib-ethersjs6`) | ||
| - [basic-transfers](./libs/ethersjs/v6/basic-transfers) |
Contributor
There was a problem hiding this comment.
Let's be consistent with other example
basic-transfers --> basic-tx
And maybe create a separtate project for erc20-tx?
| lVoZStj5fsYOQlKmQJl6JHTOARAHmk8OL4LyFDI9dp8V15UqXgo= | ||
| -----END RSA PRIVATE KEY-----' | ||
|
|
||
| ETHEREUM_NODE_URL='https://ethereum-goerli.publicnode.com' |
Contributor
There was a problem hiding this comment.
https://ethereum-sepolia-rpc.publicnode.com
Goerli is dead :D
| - `DFNS_CRED_ID` = the `Signing Key Cred ID` from above | ||
| - `DFNS_PRIVATE_KEY` = the private key from the step 'generate a keypair', the newlines should not be a problem | ||
| - `DFNS_AUTH_TOKEN` = the `authToken` from above, the value should start with `eyJ0...` | ||
| - `ETHEREUM_NODE_URL` = an Ethereum Goerli RPC provider node you have access to |
| dotenv.config() | ||
|
|
||
| const main = async () => { | ||
| // await nativeTransfer() |
Contributor
There was a problem hiding this comment.
I would prefer to be consistent with other project and maybe have 2 different example? (even if they are both simple and look alike?
Not really important, that's just a preference
| { | ||
| "extends": "../../../../../tsconfig.base.json", | ||
| "include": ["src/**/*.ts"] | ||
| // "compilerOptions": { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.