fix(test): resolve rate-limit failures when downloading datasets#9658
Open
shiva-istari wants to merge 2 commits intomainfrom
Open
fix(test): resolve rate-limit failures when downloading datasets#9658shiva-istari wants to merge 2 commits intomainfrom
shiva-istari wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
area/testing
This comment has been minimized.
This comment has been minimized.
shiva-istari
force-pushed
the
shiva/ci-downloads
branch
from
adc1378 to
12d07b5
Compare
mwelles-istari
suggested changes
Mar 16, 2026
mwelles-istari
suggested changes
Mar 16, 2026
mlwelles
requested changes
Mar 16, 2026
Contributor
mlwelles
left a comment
mlwelles
left a comment
There was a problem hiding this comment.
Additional findings beyond the code duplication and cache key concerns already noted:
Note: t/t.go:1133 still has var suffix = "?raw=true" which gets appended to media.githubusercontent.com URLs via baseUrl + name + suffix. The ?raw=true parameter is a GitHub blob-URL convention and is unnecessary for direct CDN URLs. Not harmful, but misleading — should be removed for consistency with the other URL updates in this PR.
matthewmcneely
pushed a commit
that referenced
this pull request
Mar 19, 2026
## Summary - Bumps Trivy from `0.65.0` to `0.69.3` in `.trunk/trunk.yaml` - Trivy `v0.65.0` was never published — the version scheme jumped from `v0.26.0` to `v0.69.2`, causing a 404 when trunk tries to download the hermetic tool binary - This fixes the "Trunk Code Quality / Check" CI failure seen on #9658 and all other PRs
shiva-istari
force-pushed
the
shiva/ci-downloads
branch
from
12d07b5 to
8175ecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI workflows on forked PRs fail with HTTP 429 (Too Many Requests) when downloading benchmark datasets from GitHub, because shared-IP runners hit rate limits on unauthenticated requests. This fix replaces GitHub web URLs with direct CDN URLs, adds retry logic with exponential backoff, limits concurrent downloads to 5, and cleans up partial files on failure. It also adds GitHub Actions caching to avoid re-downloading data files on repeat runs. Together these changes make benchmark data downloads reliable for both forked and internal CI workflows.