Notifications - Word difference on HTML style notifications should be configurable, add tests. Re #3740 #3741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… configurable, add tests. Re #3740
|
Just my thoughts: Would you not then need Would there be the possibility that the user selects Would the default {{diff}} revert back to the way it used to work? I guess that as this diff by word in notifications is effectively a new feature, whether achieved by UI or token it should be at watch level - I think the UI option would be easier for the user to understand - or - just revert back to how it used to be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe a different token is better
{{ diff:word }}and then the UI option isnt needed