Skip to content

Conversation

@dguittet
Copy link
Owner

Fixes

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

xiangao1 and others added 30 commits May 17, 2022 17:18
* Update the tests.

* Pass static intial status into prescient.
This is incompatible with upload to PyPI and I forgot to remove it when creating the release branch.
commit 9ca3f51
Author: dguittet <[email protected]>
Date:   Wed Oct 12 09:20:50 2022 -0600

    merge in latest from Xian's handle-renewable-gen
lbianchi-lbl and others added 26 commits November 30, 2022 18:53
Co-authored-by: Andrew Lee <[email protected]>
(cherry picked from commit 9de9736)
* Removing unused imports

* Removing more unused imports

* Removing yet more unused imports

* Fixing doc test issues

* Fixing missing import in __init__

* Removing most of the reamining unused imports

* Still more unused imports

Co-authored-by: Ludovico Bianchi <[email protected]>
(cherry picked from commit 7d1117c)
* Get rid of spurious time index

* Allow user to specify guess for heat duty in hx1d

* Handle units

* spelling

* value

* Fixed state fixing

* Run Black

Co-authored-by: Doug Allan <--global>
(cherry picked from commit df4d8d7)
@codecov-commenter
Copy link

Codecov Report

Base: 70.08% // Head: 70.25% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (de67791) compared to base (94d263c).
Patch coverage: 78.43% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   70.08%   70.25%   +0.16%     
==========================================
  Files         401      405       +4     
  Lines       65136    66259    +1123     
  Branches    12054    12323     +269     
==========================================
+ Hits        45653    46550     +897     
- Misses      17121    17334     +213     
- Partials     2362     2375      +13     
Impacted Files Coverage Δ
idaes/apps/grid_integration/tracker.py 98.47% <0.00%> (-1.53%) ⬇️
idaes/apps/uncertainty_propagation/sens.py 69.62% <0.00%> (ø)
idaes/commands/convergence.py 89.28% <0.00%> (+25.28%) ⬆️
idaes/commands/extensions.py 30.25% <0.00%> (-35.01%) ⬇️
idaes/core/base/costing_base.py 89.16% <ø> (ø)
idaes/models/control/__init__.py 100.00% <ø> (ø)
.../modular_properties/examples/enrtl_H2O_NaCl_KCl.py 100.00% <ø> (ø)
...ar_properties/examples/enrtl_NaBr_mixed_solvent.py 78.57% <ø> (ø)
...rties/modular_properties/state_definitions/FPhx.py 87.19% <ø> (ø)
...rties/modular_properties/state_definitions/FTPx.py 81.97% <ø> (ø)
... and 85 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants