Skip to content

Add an edit option to modify the resources#190

Draft
prabhjotbawa wants to merge 1 commit into
dgunzy:mainfrom
prabhjotbawa:agents/k8s-cluster-setup-with-flux
Draft

Add an edit option to modify the resources#190
prabhjotbawa wants to merge 1 commit into
dgunzy:mainfrom
prabhjotbawa:agents/k8s-cluster-setup-with-flux

Conversation

@prabhjotbawa

Copy link
Copy Markdown
Collaborator

No description provided.

Signed-off-by: Prabhjot Singh Bawa <prabhjotbawa@gmail.com>
@prabhjotbawa prabhjotbawa marked this pull request as draft July 4, 2026 02:26
@prabhjotbawa

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-07-03 at 11 28 44 PM Screenshot 2026-07-03 at 11 29 11 PM branch updated to test and saved

@prabhjotbawa

Copy link
Copy Markdown
Collaborator Author

Need to fix conflicts and do some more refinements

@dgunzy

dgunzy commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Hey @prabhjotbawa - this is great! I think this is a great feature add for flux9s. Thank you for spending some time on this 😄 . I do have a few thoughts, and i know this is only in draft state so far.

  • I think we should not write our own editor, and use a system one - maybe with a precedance something like:

    1. FLUX9S_EDITOR (tool-specific override — k9s uses K9S_EDITOR)
    2. flux9s config editor value
    3. $VISUAL (Unix convention: full-screen editors)
    4. $EDITOR
    5. fallback vi
  • Lets make this a SSA - server side apply - and ensure it fails / exits if the underlying resource has been changed.

  • I think edit_mode might be redundant, lets keep it to just following the readonly field. Technically you are writing to the flux CR's when you suspend, resume, reconcile etc. So just block any edit in readonly mode, allow it while readonly is off.

Let me know if this makes sense! Thanks for the work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants