chore(dev): enforce biome lint and gate it in verify + ci

Disables two style-opinion rules this codebase deliberately violates
(noNonNullAssertion, noExplicitAny) — enforcing them would be disproportionate
churn for no correctness gain. With the remaining rules clean, lint joins
format + typecheck + test + build in `bun run verify` and blocks in the CI
quality job. Removes the now-obsolete check:advisory script.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Piqz8qJ21eRpPrmWwxr6fg

Author: dhanesh

.github/workflows/ci.yml

@@ -21,10 +21,9 @@ jobs:
     with:
       fail-on-gaps: false  # Set to true to fail on non-blocking gaps
 
-  # Static quality gate: formatting (Biome) + typecheck both block. Linting is
-  # advisory for now (pre-existing debt); promote it to blocking once clean.
+  # Static quality gate: formatting, linting (Biome) and typecheck all block.
   quality:
-    name: Format & Typecheck
+    name: Format, Lint & Typecheck
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v6
@@ -42,13 +41,12 @@ jobs:
       - name: Check formatting
         run: bun run format:check
 
+      - name: Lint
+        run: bun run lint
+
       - name: Typecheck
         run: bun run typecheck
 
-      - name: Lint (advisory, non-blocking)
-        continue-on-error: true
-        run: bun run check:advisory
-
   # Run tests
   test:
     name: Tests

CONTRIBUTING.md

@@ -6,15 +6,14 @@
 
 ```bash
 bun install                     # Install dependencies (includes commit hooks)
-bun run verify                  # One command: format check + tests + build (the pre-PR gate)
+bun run verify                  # One command: format + lint + typecheck + tests + build
 bun run format                  # Auto-fix formatting (Biome)
 ```
 
 `bun run verify` is the single entrypoint an agent or contributor runs before a PR: it
-checks formatting (Biome), typechecks (`tsc --noEmit`), runs the full test suite, and
-rebuilds all artifacts (catching plugin-sync drift). `bun run check:advisory` runs lint,
-which is **advisory** today due to pre-existing debt — it reports but doesn't block. Promote
-it into `verify` once clean.
+checks formatting and lint (Biome), typechecks (`tsc --noEmit`), runs the full test suite,
+and rebuilds all artifacts (catching plugin-sync drift). All five gate — CI runs the same
+checks. `bun run format` auto-fixes formatting; `bun run lint` reports lint issues.
 
 ## Commit Convention
 

biome.json

@@ -11,12 +11,12 @@
       "install/**/*.ts",
       "lib/**/*.ts",
       "scripts/**/*.ts",
-      "!**/node_modules/**",
-      "!**/dist/**",
+      "!**/node_modules",
+      "!**/dist",
       "!**/*.bundle.js",
       "!**/*.generated.ts",
-      "!plugin/**",
-      "!**/__tests__/**/fixtures/**"
+      "!plugin",
+      "!**/__tests__/**/fixtures"
     ]
   },
   "formatter": {
@@ -35,7 +35,13 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "recommended": true,
+      "style": {
+        "noNonNullAssertion": "off"
+      },
+      "suspicious": {
+        "noExplicitAny": "off"
+      }
     }
   }
 }

package.json

@@ -14,8 +14,7 @@
     "format:check": "biome format .",
     "lint": "biome lint .",
     "typecheck": "cd cli && bun run typecheck",
-    "check:advisory": "echo '--- advisory (non-blocking): lint has pre-existing debt; promote to verify once clean ---' && (bun run lint || true)",
-    "verify": "bun run format:check && bun run typecheck && bun test && bun run build:all"
+    "verify": "bun run format:check && bun run lint && bun run typecheck && bun test && bun run build:all"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.5.2",