Allows binding of custom LocaleProviders #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new LocaleProvider can be bound to a custom implementation that does not necessarily use the browser locale. This is useful if the Locale should be mapped to a specific value for a custom domain name for example.
The new LocaleProvider can be bound to a custom implementation that does not necessarily use the browser locale. This is useful if the Locale should be mapped to a specific value for a custom domain name for example.
… localeProvider Conflicts: sitebricks/src/main/java/com/google/sitebricks/SitebricksModule.java sitebricks/src/main/java/com/google/sitebricks/locale/LocaleProvider.java sitebricks/src/main/java/com/google/sitebricks/locale/LocaleProviderImpl.java
|
Dhanji R. Prasanna » sitebricks #185 UNSTABLE |
Exchanged the HttpServletRequest with the new LocaleProvider.
|
Dhanji R. Prasanna » sitebricks #186 SUCCESS |
Author
|
Is there any progress on this? Some feedback would be really cool. Thank you! |
|
Dhanji R. Prasanna » sitebricks #194 SUCCESS |
|
Dhanji R. Prasanna » sitebricks #195 SUCCESS |
|
Dhanji R. Prasanna » sitebricks #196 SUCCESS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the current implementation to allow bindings of custom LocaleProviders that may behave differently and not rely (entirely) on the locale provided from the browser. A use case could be to disable some languages for custom domains.
For this to work one has only to override the SitebricksModule#bindLocaleProvider() method with a custom binding.