Fix path traversal and deserialization vulnerabilities in cmap code #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhdaines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug inherited from pdfminer.six, fixed there in pdfminer/pdfminer.six@b808ee0
Also removes the useless CMAP_PATH environment variable which could (theoretically...) be used for privilege escalation.
This is a quick patch to the problem, which also eliminates some nonsense in the way cmap files are loaded, but fundamentally cmap should NOT BE USING PICKLE! and in fact pdfminer.six once upon a time had a PR for that which wasn't accepted.
More comprehensive fix to cmap to follow later, but we need to release this now.