fix: [DHIS2-16869] Capture top-bar showing UID when editing attribute #4381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikmv
changed the title
|
🚀 Deployed on https://deploy-preview-4381.capture.netlify.dhis2.org |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the capture top-bar was displaying UIDs instead of readable names when editing attributes. The fix updates the useTeiDisplayName.ts hook to properly handle the TetAttribute type structure.
- Updated
getTetAttributesfunction to work withTetAttribute[]instead of{ id: string }[] - Changed attribute ID extraction to use
trackedEntityAttribute.idpath - Fixed variable naming consistency from
teiNameDisplayInReportstoteiNameDisplayInList
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
simonadomnisoru
approved these changes
Oct 27, 2025
dhis2-bot
added a commit
that referenced
this pull request
Oct 27, 2025
## [104.6.2](v104.6.1...v104.6.2) (2025-10-27) ### Bug Fixes * [DHIS2-16869] Capture top-bar showing UID when editing attribute ([#4381](#4381)) ([2c52f39](2c52f39))
Contributor
|
🎉 This PR is included in version 104.6.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-16869
This PR updates the handling of tracked entity type attributes in
useTeiDisplayName.ts.The function
getTetAttributesnow works with theTetAttributetype and extracts IDs fromtrackedEntityAttribute.idinstead of a top-levelid.Changes:
getTetAttributesacceptsTetAttribute[]instead of{ id: string }[]trackedEntityAttribute.id