Skip to content

Conversation

@henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Oct 1, 2025

DHIS2-20258

This pull request fixes parsing issues in the yarn i18n:add command. The issue was caused by optional chaining, which isn’t supported by the older parser in i18next-scanner. Issue resolved by removing optional chaining in the affected code. The extraction now runs successfully with "No i18n updates found!".

@henrikmv henrikmv marked this pull request as ready for review October 1, 2025 15:44
@henrikmv henrikmv requested a review from a team as a code owner October 1, 2025 15:44
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

Copy link
Contributor

@superskip superskip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👏

@henrikmv henrikmv merged commit bee6c56 into master Oct 14, 2025
43 checks passed
@henrikmv henrikmv deleted the DHIS2-20258 branch October 14, 2025 09:18
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 104.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants