feat: [DHIS2-18739] Update feedback and indicator widgets in the Registration page #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-4385.capture.netlify.dhis2.org |
src/core_modules/capture-core/components/WidgetFeedback/index.ts
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.container.ts
Outdated
Show resolved
Hide resolved
henrikmv
added
e2e record
Contributor
simonadomnisoru
left a comment
simonadomnisoru
left a comment
There was a problem hiding this comment.
Hi @henrikmv, the overall approach looks good to me now! Let’s just make sure we also have the proper types in place too.
src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.types.ts
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.types.ts
Outdated
Show resolved
Hide resolved
src/core_modules/capture-core/components/WidgetFeedback/WidgetFeedback.types.ts
Outdated
Show resolved
Hide resolved
|
simonadomnisoru
approved these changes
Oct 22, 2025
dhis2-bot
added a commit
that referenced
this pull request
Oct 22, 2025
# [104.4.0](v104.3.0...v104.4.0) (2025-10-22) ### Features * [DHIS2-18739] Update feedback and indicator widgets in the Registration page ([#4385](#4385)) ([d2713d5](d2713d5))
Contributor
|
🎉 This PR is included in version 104.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHIS2-18739
This pull request updates the feedback and indicator widgets in the registration page so they look consistent with the widget in the Enrollment dashboard.
Architecture updates
FeedbacksSectionandIndicatorsSectioncomponents inDataEntryWidgetOutput.component.tsxandLayoutComponentConfig.tswith new container files:WidgetFeedbackandWidgetIndicator. This change ensures that we consistently use the container files for the widgets around the app.Props improvement
emptyTextprop tofeedbackEmptyTextandindicatorEmptyTextin widget components and types for clearer intent and consistencyCleanup
renderCardActionsprop fromDataEntryWidgetOutputand its usages in registration components