feat: [DHIS2-21941] Self contained changelog widget - #4690
Conversation
|
🚀 Deployed on https://deploy-preview-4690.capture.netlify.dhis2.org |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…etchFormattedValues logic
henrikmv
changed the title
…vent-view-mode' into hv/chore/DHIS2-21941_SingleSourceChangelogValues
| entityId: string, | ||
| ) => queryClient.removeQueries([ReactQueryAppNamespace, 'changelog', entityType, entityId]); | ||
|
|
||
| export const removeEventChangelogQueries = (queryClient: QueryClient, eventId: string) => |
There was a problem hiding this comment.
Overall, this refactor initiative looks ok to me. But I was thinking about invalidating the cache when an event's status changes, and I think the following use cases are not covered at the moment:
- The
Scenario: User can complete the enrollment and the active eventsfeature
- Completing events from the working lists
Should we address these in preparation for DHIS2-21919, or leave them for later? Thanks!
There was a problem hiding this comment.
Nice catch! I’ll do all the preparation for DHIS2-21919 now, which means including invalidating all the necessary caches.
Thanks!
|
2 participants
DHIS2-21941
This PR makes changelog widgets self-contained by removing the
entityData/eventData/trackedEntityDataprops that were passed down from parent components. Instead, the changelog now fetches current entity values directly from the tracker API via a newuseCurrentEntityValueshook.Key changes
New
useCurrentEntityValueshook — fetches current values fromtracker/events/{id}ortracker/trackedEntities/{id}, replacing the prop-based approach.Improved
isLatestValuedetection — previously comparedchange.currentValueagainst a prop-provided snapshot. Now validates against both the newest changelog entry per field and fresh API data.Centralized
removeChangelogQueries— extracts duplicated cache invalidation into a shared utility, and adds invalidation for two new mutation sites:CompletionMenuItemandSkipAction.Opening the changelog now fires one extra tiny
tracker/{events|trackedEntities}/{id}?fields=…[…,value]fetch, but it runs in parallel with the (slower) changelog list request, is cached withstaleTime: Infinityso reopens are free, and is skipped entirely for changelogs withoutFILE_RESOURCE/IMAGEfields. In return, the widget becomes fully self-contained — no more entityData prop drilled from three different-shaped parent sources, and no more fragile?.valuehack that silently broke on stale parent caches.