-
Notifications
You must be signed in to change notification settings - Fork 378
refactor: annotation mapping #20818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: annotation mapping #20818
Conversation
| */ | ||
| @Entity | ||
| @Table(name = "categorycombo") | ||
| @Setter |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
IdentifiableObject.setSharing
This method overrides
IdentifiableObject.setName
This method overrides
IdentifiableObject.setCode
This method overrides
IdentifiableObject.setId
| @JacksonXmlRootElement(localName = "optionSet", namespace = DxfNamespaces.DXF_2_0) | ||
| public class OptionSet extends BaseIdentifiableObject implements VersionedObject, MetadataObject { | ||
| private List<Option> options = new ArrayList<>(); | ||
| @Setter |
Check notice
Code scanning / CodeQL
Missing Override annotation Note
IdentifiableObject.setAccess
This method overrides
IdentifiableObject.setSharing
This method overrides
IdentifiableObject.setCreatedBy
This method overrides
IdentifiableObject.setName
This method overrides
IdentifiableObject.setLastUpdatedBy
This method overrides
IdentifiableObject.setLastUpdated
This method overrides
IdentifiableObject.setCreated
This method overrides
IdentifiableObject.setCode
This method overrides
IdentifiableObject.setUid
This method overrides
IdentifiableObject.setId
|
The option set hbm file is being removed, is there a reason why the other 2 hbm files are not? |
jbee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Great work!
I was confused by the same thing first, I checked at least for the |
|
@david-mackessy Nice catch, remove those hbm files now. I was using the hibernate config to make use of the annotation mapping. |



Summary
CategoryCombo,DataSetElement,OptionSet.jakarta.persistencepackage together a few specific fromorg.hibernate.annotations.BaseIdentifiableObjectfor affected classes. We will need to create another Base Class which comply with annotation mapping rules.Test