Skip to content

perf: batch-fetch ProgramRule.programRuleActions to avoid per-rule N+1 #24809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jason-p-pickering wants to merge 3 commits into
base: 2.41
Choose a base branch
from
Draft

perf: batch-fetch ProgramRule.programRuleActions to avoid per-rule N+1 #24809

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c948c1a
perf: batch-fetch ProgramRule.programRuleActions to avoid per-rule N+1
jason-p-pickering Aug 8, 2026
11211c7
fix: remove illegal '--' from ProgramRule.hbm.xml comment
jason-p-pickering Aug 8, 2026
a37e528
Merge branch '2.41' into fix/2.41-programrule-batch-fetch
jason-p-pickering Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion ...s-service-core/src/main/resources/org/hisp/dhis/programrule/hibernate/ProgramRule.hbm.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,15 @@
<many-to-one name="programStage" class="org.hisp.dhis.program.ProgramStage"
column="programstageid" foreign-key="fk_programrule_programstage" />

<set name="programRuleActions" cascade="all-delete-orphan">
<!-- batch-size: without it, mapping all ProgramRules to rule-engine Rules
(DefaultProgramRuleEntityMapperService.toMappedProgramRules) lazily inits this
collection once per distinct ProgramRule, live-traced as ~400 single-row
"WHERE programruleid = ?" SELECTs per request. L2 cache doesn't help here since
each rule is a first-touch within the request, not a repeat lookup. batch-size
folds pending collection inits within one session into WHERE programruleid IN (...)
batches instead. Same category as the CategoryOption/Option batch-size="100"
precedent already in this codebase. -->
<set name="programRuleActions" cascade="all-delete-orphan" batch-size="100">
<cache usage="read-write"/>
<key column="programruleid" />
<one-to-many class="org.hisp.dhis.programrule.ProgramRuleAction" />
Expand Down
Loading