-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config, engine): add support for Mistral AI provider and engine #436
feat(config, engine): add support for Mistral AI provider and engine #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job, thank you for contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you forgot to add the dependency to package.json
fcec194
to
a4c0ed2
Compare
@di-sukharev thanks! done |
@pedro-valentim something is off with the unit-test, check pls |
Signed-off-by: Emmanuel Ferdman <[email protected]>
1ada6ff
to
f4032af
Compare
I recreated npm lock file with correct node version, we can try again... thx |
@pedro-valentim something is off with this line:
mb they have a breaking change and we need to revert the library back or just fix the export path or function name? |
hmmm, i was able to reproduce the error locally when using node v20.18.1 (v20 latest) and it seems to be resolved now we can try again |
} catch (error) { | ||
const err = error as Error; | ||
if ( | ||
axios.isAxiosError<{ error?: { message: string } }>(error) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wont be hit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remove the try/catch from the engines and prob do one try/catch in the Engine
* 378: fix hook env (#402) * fix(prepare-commit-msg-hook): update error handling to provide clearer instructions for setting API keys and improve user guidance * Fix: a bug that causes an error when pushing without setting git remote (#396) * update deploy commands * feat(cli): add context flag for providing additional commit message input * Fix [Bug]: punycode` module is deprecated #426 (#433) Signed-off-by: Tiger Kaovilai <[email protected]> * npm audit fix (#432) Signed-off-by: Tiger Kaovilai <[email protected]> * Feat: Add an option to `Don't push` when there are multiple git remotes (#434) --------- Co-authored-by: GPT8 <[email protected]> * feat(engine): add support for MLX AI provider (#437) --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Emmanuel Ferdman <[email protected]> * feat(config, engine): add support for Mistral AI provider and engine (#436) * docs(CONTRIBUTING.md): update `TODO.md` reference (#435) Signed-off-by: Emmanuel Ferdman <[email protected]> * feat(config, engine): add support for Mistral AI provider and engine * ``` feat(package): add mistralai and zod dependencies ``` * fix: recreate package-lock.json with node20 * fix: recreate package-lock.json with node v20.18.1 based on branch dev --------- Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Emmanuel Ferdman <[email protected]> Co-authored-by: pedro-valentim <> --------- Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Takanori Matsumoto <[email protected]> Co-authored-by: BILLY Maxime <[email protected]> Co-authored-by: Welington Sampaio <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> Co-authored-by: albi ⚡️ <[email protected]> Co-authored-by: Emmanuel Ferdman <[email protected]> Co-authored-by: Pedro Valentim Silva Leite <[email protected]>
feat(engine): add support for Mistral AI engine
feat(config): add Mistral AI provider to model list and validators
refactor(engine): update engine interface to include MistralClient