Add backtick to excluded characters when generating table name alias #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I pulled this into #381 which added a test case for this behavior and merged that. Thanks! |
Author
|
Thanks to you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the
generateSqlTableAliasfunction where table names that are reserved words in MySQL (e.g.,grouporuser) or simply enclosed in backticks were not properly handled.Table names that are reserved words must be enclosed in backticks (e.g.,
$this->setTableName('`group`');in the model definition). However, this backtick was incorrectly used as the initial letter for the alias (e.g.,SELECT Group g), causing unexpected behavior.This PR ensures that reserved table names can be correctly enclosed in backticks without affecting alias generation.