Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
fail-fast: false
matrix:
operating-system: [ubuntu-latest]
php-versions: ["7.4", "8.0", "8.1", "8.2", "8.3"]
php-versions: ["8.1", "8.2", "8.3", "8.4"]
composer-args: ["", "--prefer-lowest"]
runs-on: ${{ matrix.operating-system }}
steps:
Expand All @@ -40,7 +40,7 @@ jobs:
- name: Test
run: composer test-with-coverage
- name: Upload Coverage
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
with:
Expand Down
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@
}
],
"require": {
"php": "^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"ext-pdo": "*",
"symfony/yaml": "^3.4 || ^4.1 || ^5.0 || ^6.0 || ^7.0"
"symfony/yaml": "^5.0 || ^6.0 || ^7.0"
},
"require-dev": {
"phpunit/php-code-coverage": "^9.1.10",
"friendsofphp/php-cs-fixer": "^3.51.0",
"phpstan/phpstan": "1.11.3",
"vimeo/psalm": "5.24.0"
"friendsofphp/php-cs-fixer": "^3.75.0",
"phpstan/phpstan": "2.1.17",
"vimeo/psalm": "6.11.0"
},
"scripts": {
"test": "cd tests && php run.php",
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Cli.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ class Doctrine_Cli
* @param array $config
* @param Doctrine_Cli_Formatter|null $formatter Doctrine_Cli_Formatter
*/
public function __construct(array $config = array(), Doctrine_Cli_Formatter $formatter = null)
public function __construct(array $config = array(), ?Doctrine_Cli_Formatter $formatter = null)
{
$this->setConfig($config);
$this->setFormatter($formatter ? $formatter : new Doctrine_Cli_AnsiColorFormatter());
Expand Down
6 changes: 3 additions & 3 deletions lib/Doctrine/Collection.php
Original file line number Diff line number Diff line change
Expand Up @@ -932,7 +932,7 @@
* @param bool $processDiff
* @return $this
*/
public function save(Doctrine_Connection $conn = null, $processDiff = true)
public function save(?Doctrine_Connection $conn = null, $processDiff = true)
{
if ($conn == null) {
$conn = $this->_table->getConnection();
Expand Down Expand Up @@ -968,7 +968,7 @@
* @param bool $processDiff
* @return $this
*/
public function replace(Doctrine_Connection $conn = null, $processDiff = true)
public function replace(?Doctrine_Connection $conn = null, $processDiff = true)

Check warning on line 971 in lib/Doctrine/Collection.php

View check run for this annotation

Codecov / codecov/patch

lib/Doctrine/Collection.php#L971

Added line #L971 was not covered by tests
{
if ($conn == null) {
$conn = $this->_table->getConnection();
Expand Down Expand Up @@ -1002,7 +1002,7 @@
* @param bool $clearColl
* @return $this
*/
public function delete(Doctrine_Connection $conn = null, $clearColl = true)
public function delete(?Doctrine_Connection $conn = null, $clearColl = true)
{
if ($conn == null) {
$conn = $this->_table->getConnection();
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Connection/Mssql.php
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public function quoteIdentifier($str, $checkOption = false)
* @link http://lists.bestpractical.com/pipermail/rt-devel/2005-June/007339.html
* @return string
*/
public function modifyLimitQuery($query, $limit = false, $offset = false, $isManip = false, $isSubQuery = false, Doctrine_Query $queryOrigin = null)
public function modifyLimitQuery($query, $limit = false, $offset = false, $isManip = false, $isSubQuery = false, ?Doctrine_Query $queryOrigin = null)
{
if ($limit === false || !($limit > 0)) {
return $query;
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Locator.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
* @param array $defaults
* @return void
*/
public function __construct(array $defaults = null)
public function __construct(?array $defaults = null)

Check warning on line 59 in lib/Doctrine/Locator.php

View check run for this annotation

Codecov / codecov/patch

lib/Doctrine/Locator.php#L59

Added line #L59 was not covered by tests
{
if (null !== $defaults) {
foreach ($defaults as $name => $resource) {
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Query.php
Original file line number Diff line number Diff line change
Expand Up @@ -2251,7 +2251,7 @@ public function query($query, $params = array(), $hydrationMode = null)
*
* @return Doctrine_Query Copy of the Doctrine_Query instance.
*/
public function copy(Doctrine_Query $query = null)
public function copy(?Doctrine_Query $query = null)
{
if (! $query) {
$query = $this;
Expand Down
4 changes: 2 additions & 2 deletions lib/Doctrine/Query/Abstract.php
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ abstract class Doctrine_Query_Abstract
* @param Doctrine_Hydrator_Abstract|null $hydrator The hydrator that will be used for generating result sets.
*/
public function __construct(
Doctrine_Connection $connection = null,
Doctrine_Hydrator_Abstract $hydrator = null
?Doctrine_Connection $connection = null,
?Doctrine_Hydrator_Abstract $hydrator = null
) {
if ($connection === null) {
$connection = Doctrine_Manager::getInstance()->getCurrentConnection();
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Query/Part.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ abstract class Doctrine_Query_Part
/**
* @param Doctrine_Query $query the query object associated with this parser
*/
public function __construct($query, Doctrine_Query_Tokenizer $tokenizer = null)
public function __construct($query, ?Doctrine_Query_Tokenizer $tokenizer = null)
{
$this->query = $query;

Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/RawSql.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ class Doctrine_RawSql extends Doctrine_Query_Abstract
* @param Doctrine_Connection $connection The connection object the query will use.
* @param Doctrine_Hydrator_Abstract $hydrator The hydrator that will be used for generating result sets.
*/
public function __construct(Doctrine_Connection $connection = null, Doctrine_Hydrator_Abstract $hydrator = null)
public function __construct(?Doctrine_Connection $connection = null, ?Doctrine_Hydrator_Abstract $hydrator = null)
{
parent::__construct($connection, $hydrator);

Expand Down
8 changes: 4 additions & 4 deletions lib/Doctrine/Record.php
Original file line number Diff line number Diff line change
Expand Up @@ -1846,7 +1846,7 @@ public function resetPendingUnlinks()
* @throws Exception if record is not valid and validation is active
* @return void
*/
public function save(Doctrine_Connection $conn = null)
public function save(?Doctrine_Connection $conn = null)
{
if ($conn === null) {
$conn = $this->_table->getConnection();
Expand All @@ -1863,7 +1863,7 @@ public function save(Doctrine_Connection $conn = null)
* @param Doctrine_Connection $conn optional connection parameter
* @return bool TRUE if the record was saved sucessfully without errors, FALSE otherwise.
*/
public function trySave(Doctrine_Connection $conn = null)
public function trySave(?Doctrine_Connection $conn = null)
{
try {
$this->save($conn);
Expand All @@ -1890,7 +1890,7 @@ public function trySave(Doctrine_Connection $conn = null)
* @throws Doctrine_Connection_Exception if something fails at database level
* @return bool
*/
public function replace(Doctrine_Connection $conn = null)
public function replace(?Doctrine_Connection $conn = null)
{
if ($conn === null) {
$conn = $this->_table->getConnection();
Expand Down Expand Up @@ -2339,7 +2339,7 @@ public function getIterator()
*
* @return boolean true if successful
*/
public function delete(Doctrine_Connection $conn = null)
public function delete(?Doctrine_Connection $conn = null)
{
if ($conn == null) {
$conn = $this->_table->getConnection();
Expand Down
4 changes: 2 additions & 2 deletions lib/Doctrine/Table.php
Original file line number Diff line number Diff line change
Expand Up @@ -2068,7 +2068,7 @@ public function enumIndex($fieldName, $value)
* @param Doctrine_Record $record record to consider; if it does not exists, it is created
* @return Doctrine_Validator_ErrorStack $errorStack
*/
public function validateField($fieldName, $value, Doctrine_Record $record = null)
public function validateField($fieldName, $value, ?Doctrine_Record $record = null)
{
if ($record instanceof Doctrine_Record) {
$errorStack = $record->getErrorStack();
Expand Down Expand Up @@ -2221,7 +2221,7 @@ public function removeColumn($fieldName)
*
* @return array numeric array
*/
public function getColumnNames(array $fieldNames = null)
public function getColumnNames(?array $fieldNames = null)
{
if ($fieldNames === null) {
return array_keys($this->_columns);
Expand Down
2 changes: 0 additions & 2 deletions lib/Doctrine/Transaction.php
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,6 @@ private function removeSavePoints($savepoint)
* SERIALIZABLE (prevents phantom reads)
*
* @throws Doctrine_Transaction_Exception if the feature is not supported by the driver
* @throws PDOException if something fails at the PDO level
* @return PDOStatement|Doctrine_Adapter_Statement_Interface
*/
public function setIsolation($isolation)
Expand All @@ -507,7 +506,6 @@ public function setIsolation($isolation)
* but not fetching it
*
* @throws Doctrine_Transaction_Exception if the feature is not supported by the driver
* @throws PDOException if something fails at the PDO level
* @return string returns the current session transaction isolation level
*/
public function getIsolation()
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Transaction/Mysql.php
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public function getIsolation()
{
// Mysql 5.7.20 added `@@transaction_isolation` as an alias for `@@tx_isolation`
// Mysql 8.0.0 removes `@@tx_isolation`
if (version_compare($this->mysqlVersion, '5.7.20', '>=')) {
if (version_compare((string) $this->mysqlVersion, '5.7.20', '>=')) {
return $this->conn->fetchOne('SELECT @@transaction_isolation');
}

Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Tree/Interface.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ interface Doctrine_Tree_Interface
* @param Doctrine_Record $record instance of Doctrine_Record
* @return Doctrine_Record
*/
public function createRoot(Doctrine_Record $record = null);
public function createRoot(?Doctrine_Record $record = null);

/**
* returns root node
Expand Down
2 changes: 1 addition & 1 deletion lib/Doctrine/Tree/NestedSet.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public function setTableDefinition()
* @param Doctrine_Record $record instance of Doctrine_Record
* @return Doctrine_Record
*/
public function createRoot(Doctrine_Record $record = null)
public function createRoot(?Doctrine_Record $record = null)
{
if ($this->getAttribute('hasManyRoots')) {
if (! $record || (! $record->exists() && ! $record->getNode()->getRootValue())
Expand Down
Loading