Fix isValidType for JSON type #384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #384 +/- ##
============================================
+ Coverage 69.96% 70.03% +0.07%
- Complexity 7724 7727 +3
============================================
Files 262 262
Lines 18383 18383
============================================
+ Hits 12862 12875 +13
+ Misses 5521 5508 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| return true; | ||
| } elseif ($type === 'json') { | ||
| // JSON type can be object, array, string, number, boolean, or null (null handled above) | ||
| return is_object($var) || is_array($var) || is_string($var) || is_numeric($var) || is_bool($var); |
There was a problem hiding this comment.
So you're basically checking for:
is_object($var) || is_array($var) || is_scalar($var) || is_null($var), right?
=> basically everything except resources, callables and such
Note the fine difference that is_numeric() !== (is_int() || is_float()) ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #383
This changes the isValidType method to explicitly check for the "json" type and returns true if the var is a valid type for a "json" column.