add arg --outfile #272
add arg --outfile #272
Conversation
- default behaviour: if --outfile is not given or equals "STDOUT" then the signed cert is printed to STDOUT as legacy - otherwise the file given with --outfile is opened for write and sigend cert is written to it (no handling of mode bits, because the cert is no secret)
this should fix the test errors
|
@btwe It looks like this pull request puts acme-tiny over the 200 line limit, so I'm not going to merge it for now. However, I'll keep this pull request open if I decide to increase the line limit, I can merge this. |
|
I understand, this would change the selling point. But let me try to show another aspect: The line count limit itself does not increase readability. I think you could somehow squeeze the output conditional into a single line. But readability of the source is also a selling point for acme-tiny. My little experience is that trying to stick to pep8 might also increase readability with the human eye, but of course this would blow the 200 lines by a lot (~70) Don't get me wrong, I do not intend to convince you of changing anything. I know how to patch this PR in on my side; also thanks to the small code base, it is very easy to do this. So, thanks a lot for your work on acme-tiny and publishing it. I have this PR on watch so I'll get updated 👍 |
2 participants
I have acme-tiny integrated as a systemd service + a timer. I find it handy to also specify an outfile, where the signed certificate + chain should be written to.
Of course, the default behaviour remains, which prints the signed cert to STDOUT.
Output with
--outfile /etc/pki/acme/domainA.cert:Output without
--outfile: