fix: delete broken task-dump examples and fix CI to catch example failures#180
Merged
Merged
Conversation
…lures The `task_dump` module was removed but 4 examples (long_sleep, completing_task, cancelled_task, debug_timing) and 1 bench (poll_overhead) that depended on it were left behind. These compiled fine in the default CI because: 1. `cargo build` didn't use `--all-features` or `--all-targets`, so feature-gated examples were never compiled 2. `cargo clippy` didn't use `--all-targets` or `--all-features`, so examples and feature-gated code were not linted Only the nightly stress test (which uses `--all-features`) caught the breakage. Changes: - Delete 4 broken task-dump examples and 1 broken bench - Remove the `task-dump` feature from Cargo.toml and README - Build action: `cargo build` → `cargo build --all-targets --all-features` - Build action: `cargo test` → `cargo test --all-features` - Clippy: `cargo clippy --workspace` → `cargo clippy --all-targets --all-features`
rcoh
force-pushed
the
fix/delete-broken-task-dump-examples-fix-ci
branch
from
ec49afb to
1e98bd8
Compare
yulnr
approved these changes
Apr 10, 2026
jlizen
approved these changes
Apr 10, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The nightly stress test (run #24232680975) is failing because 4 examples and 1 bench reference
dial9_tokio_telemetry::task_dump, a module that was previously removed.The main CI (
build.yml) didn't catch this because:cargo buildran without--all-featuresor--all-targets, so feature-gated examples were never compiledcargo clippyran with--workspacebut without--all-targetsor--all-features, so examples and feature-gated code were not lintedOnly the stress test (which uses
--all-features) caught the breakage.Changes
Delete broken code:
long_sleep,completing_task,cancelled_task,debug_timingpoll_overheadtask-dumpfeature fromCargo.tomlandREADME.mdFix CI to prevent this class of bug:
cargo build→cargo build --all-targets --all-featurescargo test→cargo test --all-featurescargo clippy --workspace→cargo clippy --all-targets --all-featuresHousekeeping:
cargo fmtviolations inwriter.rs