fix: rate_limit log when drain is failing#385
Merged
Conversation
jlizen
approved these changes
May 9, 2026
jlizen
left a comment
jlizen
left a comment
Member
There was a problem hiding this comment.
Thanks for adding the new test infra!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when
drainedreturns an io error, we would call it in a hot-ish (5ms delay) loop and create a lot of logspam.There is a more nuanced consideration to how we should handle when the drain command is erroring that probably depends on the root cause of the individual error but this fixes the logspam.