docs(design): in-memory pipeline#389
Merged
Merged
Conversation
rcoh
reviewed
May 11, 2026
rcoh
approved these changes
May 14, 2026
rcoh
left a comment
rcoh
left a comment
Contributor
There was a problem hiding this comment.
seems pretty much good, worth a prototype
| /// via [`Fs::seal`]. | ||
| pub trait Fs: Send + Sync + 'static { | ||
| // --- Write side --- | ||
| fn create(&self, path: &Path) -> io::Result<Box<dyn Write + Send>>; |
Contributor
There was a problem hiding this comment.
probably fine but we should benchmark. I would not be surprised if you get significant wins from being able to optimize on the specific type in use.
yulnr
force-pushed
the
docs/in-memory-pipeline-design
branch
from
2e2c02b to
b66fee8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#279
Adds a design document for the implementation of a full in-memory pipeline that does not rely on writing to disk.
The last section (# 7 open questions) includes some of the items that I don't have any strong preference on.