Conversation
jlizen
approved these changes
May 11, 2026
jlizen
left a comment
jlizen
left a comment
Member
There was a problem hiding this comment.
Good rewrite. some small things.
| ## Quick Start | ||
|
|
||
| ## Is there a demo? | ||
| dial9 is fundamentally an efficient way to collect data from [different sources](#data-sources) then [export them out of the application](#getting-data-out-of-dial9). You can enable as many different data sources as you need to debug (or as few as you can tolerate the overhead of in production.) |
Member
There was a problem hiding this comment.
This seems a bit odd to have at the start of quickstart. I would have expected to lead with code samples.
| ## Data sources | ||
|
|
||
| #### Requirements | ||
| dial9 is fundamentally a central buffer that can collect data from different sources. You can pull in as many or as few as you want. |
Member
There was a problem hiding this comment.
we say "fundamentally a"... a lot
| ``` | ||
|
|
||
| This runs the `overhead_bench` binary with and without telemetry and reports the difference. Typical output: | ||
| By default objects will be uploaded to `s3://{bucket}/{prefix}/{YYYY-MM-DD}/{HHMM}/{service_name}/{instance_path}/{boot_id}/{epoch_secs}-{index}.bin.gz`. You can customize the location with `S3Config::builder().key_fn(...)`. |
Member
There was a problem hiding this comment.
nit: this is starting to get into the, "we should have a doc page on this", level of detail territory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.