fix: bring back old API on core telemetry builder#401
Merged
Conversation
rcoh
force-pushed
the
fix-core-telemetry-builder
branch
from
5011169 to
7335822
Compare
quinnwerks
approved these changes
May 13, 2026
quinnwerks
left a comment
quinnwerks
left a comment
There was a problem hiding this comment.
Just out of curiosity: how do you think we can avoid this?
| } | ||
|
|
||
| // Custom methods on the generated builder. | ||
| impl<W: TraceWriter, S: telemetry_core_builder::State> TelemetryCoreBuilder<W, S> { |
skanjalkar
approved these changes
May 13, 2026
Contributor
Author
|
I am doing two things:
I did the second one which caught this miss. I'll cut a PR for the usage patterns as well |
jlizen
approved these changes
May 13, 2026
Member
|
Shouldn't cargo-semver-checks have caught this too @rcoh ? |
Contributor
Author
|
I don't think we are running it on PRs and running it on releases I think
is reliant on the maintainers machine? We should set that up too.
I suspect the quantity of generics may have it a path that CSC doesn't
cover though.
…On Wed, May 13, 2026, 7:57 PM Jess Izen ***@***.***> wrote:
*jlizen* left a comment (dial9-rs/dial9#401)
<#401 (comment)>
Shouldn't cargo-semver-checks have caught this too @rcoh
<https://github.com/rcoh> ?
—
Reply to this email directly, view it on GitHub
<#401 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADYKZ4Q7SVURHGLAH75PBT42UDVVAVCNFSM6AAAAACY5FNZ22VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DINBWGEZDKNRZGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
|
Yeah even if we are only running it on releases, i would have expected it to flag this as a breaking change and force a breaking version bump. Maybe it got swept up by a release that was already breaking? It would be good to run it as a non-blocking step on PRs too though. It isn't reliant on the maintainers machine, no, it just builds docs in CI and analyzes them. Anyway certainly possible that CSC also got confused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR removed
.s3_configas an option on TelemetryCoreBuilder, this brings it back