Rework release CI & add semver checks#409
Merged
Merged
Conversation
jlizen
approved these changes
May 15, 2026
| ``` | ||
| 1. Merge your PRs to `main` using conventional commit messages (e.g. `feat:`, `fix:`, `feat!:` for breaking changes). | ||
| 2. The release PR will update automatically. Review the changelog and version bumps. | ||
| 3. If you need to adjust versions (e.g. force a major bump), edit `Cargo.toml` versions in the release PR before merging. |
Member
There was a problem hiding this comment.
Might also be worth mentioning changelog improvements / adding code samples is encouraged?
| 2. The release PR will update automatically. Review the changelog and version bumps. | ||
| 3. If you need to adjust versions (e.g. force a major bump), edit `Cargo.toml` versions in the release PR before merging. | ||
| 4. Merge the release PR. | ||
| 5. Go to Actions → "Publish release" → Run workflow → confirm. |
Member
There was a problem hiding this comment.
We did it this way to keep the token narrower?
Contributor
Author
There was a problem hiding this comment.
it also means we can decouple changing versions in cargo.toml and clicking release
Member
There was a problem hiding this comment.
Wouldn't we get that anyway if we only released from the release-plz pr?
But anyway this is fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks CI slightly:
Releases are not automatic anymore. They MUST be triggered manually. So the flow is now: merge release PR -> cut release. The doc now covers this. This is a little bit more secure and it also makes releasing a bit cleaner.
Added tags for all github actions.