feat: add tid to WorkerParkEvent and WorkerUnparkEvent#410
Merged
Conversation
Add `tid: u32` to both events so the trace is self-describing for thread-role attribution. Previously, analysis tools had to query runtime state at flush time to recover the tid→worker_id mapping, which only works while the runtime is alive. The field is stamped via `events::current_tid()` (one gettid syscall on Linux, ~5 ns) in the existing park/unpark hooks. This is an additive schema change: old JS/Rust decoders ignore unknown fields in the schema-driven format.
jlizen
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
tid: u32to both events so the trace is self-describing for thread-role attribution. Previously, analysis tools had to query runtime state at flush time to recover the tid→worker_id mapping, which only works while the runtime is alive.The field is stamped via
events::current_tid()(one gettid syscall on Linux, ~5 ns) in the existing park/unpark hooks.This is an additive schema change: old JS/Rust decoders ignore unknown fields in the schema-driven format.
This will allow us to remove the tid attribution map and remove
WorkerIdfrom CPU samples since it will be recoverable from the unpark event which joins the events together.