Design updates for memory profiling#419
Merged
Merged
Conversation
yulnr
approved these changes
May 18, 2026
Comment on lines
+825
to
+827
| 2. **SIGSEGV handler ordering.** Applications that install their own | ||
| SIGSEGV handler after dial9 initialization may break the unwinder's | ||
| fault tolerance. |
Collaborator
There was a problem hiding this comment.
good catch! idk how common but might be worth testing and maybe documenting later for users to be aware of
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several design doc updates for memory profiling discovered during prototyping. The biggest change is a switch to using a ring buffer.
I also cleaned up the doc because a lot of the pre-requisite work is already done.