Assign button sounds to the correct audio bus#2754
Open
mrspeaker wants to merge 1 commit into
Open
Conversation
Currently Button Sounds are played through the default (master) audio bus. Button Sounds play the typing sound when hovering over a dialog option. This PR assigns the bus to the same user setting as Type Sound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Button Sounds are played through the default (master) audio bus. Button Sounds play the typing sound when hovering over a dialog option. This PR assigns the bus to the same user setting as Type Sound (in
/Modules/Text/node_type_sound.gd).This fix was for my personal project where I noticed that muting the sound-effects audio bus did not stop the hover typing sounds in dialog options.
I'm not sure why the assignment to the bus needs to be guarded with
if bus == 'Master', but this is what was done innode_type_sound.gd.