Skip to content

fixed 'Not all code paths return a value.' error for godot 4.7 #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
da-pwo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed 'Not all code paths return a value.' error for godot 4.7 #2769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions addons/dialogic/Modules/Text/node_name_label.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ func _set(property, what):
else:
name_label_root.show()
return true
else:
return false
4 changes: 4 additions & 0 deletions addons/dialogic/Modules/Variable/subsystem_variables.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ func _get(property):
return VariableFolder.new(var_storage[property], property, self)
else:
return DialogicUtil.logical_convert(var_storage[property])
else:
return null


func folders() -> Array:
Expand Down Expand Up @@ -244,6 +246,8 @@ class VariableFolder:
return VariableFolder.new(data[property], path+"."+property, outside)
else:
return DialogicUtil.logical_convert(data[property])
else:
return null


func _set(property:StringName, value:Variant) -> bool:
Expand Down