Skip to content

fix(rich-text-editor): DP-179947 use URL as display text when inserting link without text #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brad Paugh (braddialpad) merged 2 commits into from
Apr 17, 2026
Merged

fix(rich-text-editor): DP-179947 use URL as display text when inserting link without text #1202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad6c571
fix(rich-text-editor): DP-179947 use URL as display text when inserti…
braddialpad Apr 15, 2026
56d8b8b
test refactor
braddialpad Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions packages/dialtone-vue/components/rich_text_editor/rich_text_editor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1633,6 +1633,37 @@ describe('DtRichTextEditor tests', () => {
});
});

describe('setLink method', () => {
const linkOptions = { class: 'd-link' };
const supportedProtocols = [/^https?:\/\//, /^ftp?:\/\//, /mailto:/];
const defaultPrefix = 'https://';

beforeEach(async () => {
await wrapper.setProps({ link: true, outputFormat: 'html' });
wrapper.vm.editor.commands.focus();
});

describe('When display text is provided', () => {
it('should insert the display text as a link', async () => {
wrapper.vm.setLink('https://example.com', 'Example', linkOptions, supportedProtocols, defaultPrefix);
await wrapper.vm.$nextTick();
const output = wrapper.vm.getOutput();
expect(output).toContain('href="https://example.com"');
expect(output).toContain('Example');
});
});

describe('When display text is empty', () => {
it('should use the URL as the display text', async () => {
wrapper.vm.setLink('https://example.com', '', linkOptions, supportedProtocols, defaultPrefix);
await wrapper.vm.$nextTick();
const output = wrapper.vm.getOutput();
expect(output).toContain('href="https://example.com"');
expect(output).toContain('https://example.com');
});
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
});
});

describe('Link keyboard shortcut functionality', () => {
describe('When Mod+K is pressed and link is enabled', () => {
it('should emit edit-link event', async () => {
Expand Down
5 changes: 3 additions & 2 deletions packages/dialtone-vue/components/rich_text_editor/rich_text_editor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,12 +974,13 @@ export default {
.run();

const selection = this.editor?.view?.state?.selection;
const displayText = linkText || linkInput;

this.editor
.chain()
.focus()
.insertContent(linkText)
.setTextSelection({ from: selection.from, to: selection.from + linkText.length })
.insertContent(displayText)
.setTextSelection({ from: selection.from, to: selection.from + displayText.length })
.setLink({ href: linkInput, class: linkOptions.class })
.run();
},
Expand Down
Loading